@TomPallister

What if timeout happens? Timeout maybe not good practice here.

Setting timeout is one of the necessary tasks of using regex. When a timeout occurs, it is best to run the entire project involved and not respond to others.

Is there some reason for considering 100ms as the regex timeout, and how could the client update the timeout config if the client wanna use a longer timeout?

timeout is not customizable by the customer. Like many other settings. It was 100 ms when I adjusted it according to the tests I had. But we can decide here and change this time. We can set this time to 500 ms. If we do not receive an answer at this time, it is better not to involve the whole project in its implementation and let it respond to other requests.

Dear Mohsen,

Why did you merge develop branch from your fork into the feature branch?
I meant these commits: ff1dbb6 5b336cd
It was unnecessary because I did the merge of ThreeMammals:develop in 329d2c3.
After that I trigger pipeline to make a valid green build for commit 03a70b3.

Now there is no build at all and pipeline cannot run new build.
The pipeline cannot recognize develop branch because you have juggled all commits in a wrong way.

Could you fix/update your fork develop branch please first?

After that we will try to fix pipeline triggering by rebasing current feature branch onto develop one.

Now I see develop and it has zero diff, but the branch is not default. ☝️
You have to go to repo settings and make develop branch as default!
I hope that should help to fix the problem of builds, because all builds are built for develop branch (auto) and master (manually).
Currently I don't see that pipeline was triggered for top commit.
Maybe an empty or tiny commit will be required to trigger the pipeline after making develop branch default.

Feature branch has been rebased onto develop!
The build has been passed for top commit!

Going to start code review...

I guess, this PR is not related to an issue, right?

@EngRajabi Hello, Mohsen! Are you energized and ready to deliver this PR? 😄

@raman @RaynaldM Again, I would have prefered moving to .NET 7-9 before to reduce the complexity and ensure a better maintainability.

@ggnaegi commented Nov 16, 2024

Please update to the desired .NET version in your forked repository, or remain on version 23.4.2, which corresponds .NET 7.
To minimize complexity and ensure better maintainability, we adhere to the standard Microsoft .NET support lifecycle, specifically the .NET and .NET Core Support Policy → .NET 7 → End of support on May 14, 2024❗
Our official end of .NET 6, 7 support is merged PRs #2220 #2221 → version 23.4.2

P.S. Ocelot is an open-source project, just like .NET framework. You would be correct if Ocelot were a commercial project, but it is not.